[ 
https://issues.apache.org/jira/browse/QPID-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350231#comment-16350231
 ] 

Keith Wall commented on QPID-8081:
----------------------------------

I think the changes look functionally correct.  As we are sub-classing 
implementation we don't own, I think we should guard against \{{activeFile}} 
actual parameter being unexpectedly null.  

Separately, the subclassing of Policies looks very fragile.  I wonder about an 
alternative:
 * {{CompositeTriggeringPolicy}} which merely delegates to list of triggering 
policies
 * {{RollOnStartupTriggeringPolicy}} which takes care of our roll on startup 
requirement
 * The Appender would be initialised with {{CompositeTriggeringPolicy}} which 
comprises a standard logback triggering policy and a 
{{RollOnStartupTriggeringPolicy}}.

We could perhaps look at this refactoring when we next upgrade Logback?

 

> [Broker] FileLogger with "roll on restart" set to "true" does not roll log 
> file on broker restart when "roll daily" is "true"
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-8081
>                 URL: https://issues.apache.org/jira/browse/QPID-8081
>             Project: Qpid
>          Issue Type: Bug
>          Components: Broker-J
>    Affects Versions: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>            Reporter: Alex Rudyy
>            Priority: Major
>             Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
>
> If "roll on restart" is set, the FileLogger should rolled over the log file 
> on every restart.
> It does not do it when "roll daily" is "on".
> We should verify that the name of log file rolled over on Broker restart 
> should conform to "roll daily" policy file name pattern: {code}fileName + 
> ".%d{yyyy-MM-dd}.%i"{code}
> We have reports that when log file is rolled over on restart (for whatever 
> reason), the file name does not conform to the expected pattern. Instead, the 
> pattern for {{SimpleRollingPolicy}} is used :{code}fileName + ".%i"{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to