Keith Wall commented on QPID-8091:

Alex - we paired on ffd5ad0, 46c49cf.  I reviewed your remaining work - mostly 
looked good.

* Using the CHN message for transaction timeout was inappropriate for AMQP 1.0. 
 I added CON messages instead.
* I want to keep broker features clearly separate within protocol tests suite, 
so I have moved the tests to a separate package.  
* I disliked the virtualhost configuration mechanism you added.  It was too 
restrictive to be generally useful.   There are places where we will want to 
configure things other then attributes of the virtualhost.  I refactored 

> [Broker-J] [AMQP 1.0] Store transaction timeout feature
> -------------------------------------------------------
>                 Key: QPID-8091
>                 URL: https://issues.apache.org/jira/browse/QPID-8091
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>            Priority: Major
>             Fix For: qpid-java-broker-7.1.0
> Berkeley JE's design means that once a transaction has begun, its internal 
> cleaner is unable to clean beyond the point the transaction started in the 
> transaction log.  Other transaction work continues as normal, but the disk 
> space utilisation can't shrink until the long running transaction is 
> completed.  In an extreme case, disk space can be exhausted.
> This has consequence for long running store transactions in Qpid.  For 0-x, 
> the transaction timeout features allows the the length of time a transaction 
> may be open or idle to be constrained, thus limiting the harmful effects of a 
> long running store transaction.
> For robustness, that features needs to be implemented on AMQP 1.0 too.   A 
> decision needs to be made about the correct course of action to be taken when 
> a long running transaction exceeds the threshold.   The transaction 
> coordinator link could be closed with an error or the entire connection 
> closed.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to