Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/247#discussion_r167675656
--- Diff: src/router_core/agent_address.c ---
@@ -54,6 +56,8 @@ const char *qdr_address_columns[] =
"deliveriesTransit",
"deliveriesToContainer",
"deliveriesFromContainer",
+ "deliveriesToRouteContainer",
+ "deliveriesFromRouteContainer",
--- End diff --
I find the names of these two new attributes misleading. They appear to be
grouped with the former two attributes "deliveriesToContainer" and
"deliveriesFromContainer" because of the similar naming. The new stats are
supposed to be grouped with "deliveriesIngress" and "deliveriesEgress". I
think better names would be "deliveriesIngressRouteContainer" and
"deliveriesEgressRouteContainer".
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
