[
https://issues.apache.org/jira/browse/QPID-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376132#comment-16376132
]
Keith Wall commented on QPID-8103:
----------------------------------
Alex,
Looks good, but I have a few comments:
# {{CSVFormat}} is from Apache Commons CSV. In the absence of any Apache advice
(I don't see any), I think we should follow the pattern of
{{SelectorParser.jj}} and quote the revision of the version in addition to the
project reference (which you have done). Furthermore, I would check-in the
original file unchanged first, then commit your changes on top so that your
(and any subsequent) changes are obvious from the original author(s)' work.
# If I switch the query tab from standard, to advanced and back to standard,
the export button no longer works.
# Dates values are being formatted "Sun Feb 25 15:38:59 GMT 2018". I guess
99% users would be using this feature with Excel, so I think the behaviour
ought to be convenient for them. Does this format work okay with Excel? I don't
have it available to test.
> [Broker-J] [WMC] [Query UI] Add ability to download results as CSV
> ------------------------------------------------------------------
>
> Key: QPID-8103
> URL: https://issues.apache.org/jira/browse/QPID-8103
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Reporter: Keith Wall
> Assignee: Alex Rudyy
> Priority: Minor
> Fix For: qpid-java-broker-7.0.2
>
> Attachments:
> 0001-QPID-8103-Broker-J-WMC-Query-UI-Add-ability-to-downl.patch
>
>
> The usefulness of the Query UI is currently hampered by the fact that it is
> impossible to download the results of the query. A useful improvement would
> be a button allowing the results of the query to be downloaded, say as a CSV.
> The {{QueryServlet}} would need to accept an optional format that allowed the
> desired format to be specified.
> Also the results table does not permit the copy gesture. There is no good
> reason for this restriction.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
