[
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376981#comment-16376981
]
ASF GitHub Bot commented on DISPATCH-918:
-----------------------------------------
Github user ChugR commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/261#discussion_r170614842
--- Diff: tests/system_tests_autolinks.py ---
@@ -53,17 +53,18 @@ def setUpClass(cls):
#
# Create a pair of default auto-links for 'node.1'
#
- ('autoLink', {'addr': 'node.1', 'containerId': 'container.1',
'dir': 'in'}),
- ('autoLink', {'addr': 'node.1', 'containerId': 'container.1',
'dir': 'out'}),
+ ('autoLink', {'addr': 'node.1', 'containerId': 'container.1',
'direction': 'in'}),
+ ('autoLink', {'addr': 'node.1', 'containerId': 'container.1',
'direction': 'out'}),
#
# Create a pair of auto-links on non-default phases for
container-to-container transfers
#
- ('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2',
'dir': 'in', 'phase': '4'}),
- ('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3',
'dir': 'out', 'phase': '4'}),
+ ('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2',
'direction': 'in', 'phase': '4'}),
+ ('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3',
'direction': 'out', 'phase': '4'}),
#
# Create a pair of auto-links with a different external address
+ # Leave the direction as dir to test backward compatibility.
--- End diff --
Is there a test that has both dir and direction specified to see that it
fails?
> Improve router config consistency and metadata
> ----------------------------------------------
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Justin Ross
> Assignee: Ganesh Murthy
> Priority: Major
>
> Proposed changes from review. The items marked PRIO1 are more important.
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can
> generate better docs from it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
