[
https://issues.apache.org/jira/browse/PROTON-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377562#comment-16377562
]
ASF subversion and git services commented on PROTON-1774:
---------------------------------------------------------
Commit 88310a5a7fe1073e95504c1cfbc69206e4b643db in qpid-proton-j's branch
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton-j.git;h=88310a5 ]
PROTON-1774 Remove sasl processing when complete
Once complete remove any impact of the SaslTransportWrapper from the
transport chain by selecting back to the next TransportWrappers for
input and output once SASL is complete and the pending buffers are
drained. Move the buffers for sasl input and output into the wrapper
which can be GC'd once removed from the chain.
> [proton-j] performance improvements in sasl transport wrapper
> -------------------------------------------------------------
>
> Key: PROTON-1774
> URL: https://issues.apache.org/jira/browse/PROTON-1774
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: proton-j-0.26.0
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: proton-j-0.27.0
>
>
> The SaslImpl class adds a TransportWrapper that deals with processing the
> iincoming and outgoing sasl exchange work. When complete the wrapper leaves
> in place an implementation that must check on each new bit of work through
> the transport if it is still in Sasl mode and hand off to the next wrapper
> accordingly when not in Sasl. This checking can lead to a small loss in
> performance. Instead a wrapper that delegates to a swappable next instance
> can be switched once sasl is complete such that no checking is required after
> the sasl exchange.
> As a side affect of this change the input and output buffers allocated to
> handle sasl bytes in the exchange can be moved to the delegate
> TransportWrapper that will be dropped after the exchange and that small bit
> of memory can be freed by a future GC.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
