[ 
https://issues.apache.org/jira/browse/DISPATCH-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387802#comment-16387802
 ] 

ASF GitHub Bot commented on DISPATCH-933:
-----------------------------------------

Github user bhardesty commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/263#discussion_r172520473
  
    --- Diff: python/qpid_dispatch/management/qdrouter.json ---
    @@ -431,37 +431,100 @@
                         "description": "Time in seconds after which link state 
is declared stale if no RA is received.",
                         "create": true
                     },
    -                "addrCount": {
    -                    "type": "integer",
    -                    "description":"Number of addresses known to the 
router.",
    -                    "graph": true
    -                },
    -                "linkCount": {
    +                "workerThreads": {
                         "type": "integer",
    -                    "description":"Number of links attached to the router 
node.",
    -                    "graph": true
    +                    "default": 4,
    +                    "description": "The number of threads that will be 
created to process message traffic and other application work (timers, non-amqp 
file descriptors, etc.) .",
    +                    "create": true
                     },
    -                "nodeCount": {
    -                    "type": "integer",
    -                    "description":"Number of known peer router nodes.",
    -                    "graph": true
    +                "debugDump": {
    +                    "type": "path",
    +                    "description": "A file to dump debugging information 
that can't be logged normally.",
    --- End diff --
    
    In that case, how about this:
    
    The absolute path to the location for the debug dump file. The router 
writes debug-level information to this file if the logger is not available.


> Introduce a new RouterStats entity and move all stats from the RouterEntity 
> to the RouterStats entity
> -----------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-933
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-933
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Management Agent
>    Affects Versions: 1.0.1
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.2.0
>
>
> Right now all router statistics attributes like deliveriesIngress, 
> rejectedDeliveries, droppedPresettledDeliveries etc. reside in the router 
> entity..
>  
> Router Config Attributes  like saslConfigPath, saslConfigName, 
> helloIntervalSeconds, helloMaxAgeSeconds etc. also reside in the router entity
>  
> When a qdmanage query is issued, the results do not include the router config 
> attributes. This is because the core does not have access to these attributes
>  
> {noformat}
> [gmurthy@localhost qpid-dispatch]$ qdmanage QUERY --type=router
> [
>   {
>     "linkRouteCount": 0,
>     "droppedPresettledDeliveries": 0,
>     "rejectedDeliveries": 0,
>     "autoLinkCount": 0,
>     "id": "Router.A",
>     "presettledDeliveries": 0,
>     "area": "0",
>     "deliveriesIngress": 1,
>     "deliveriesIngressRouteContainer": 0,
>     "acceptedDeliveries": 1,
>     "version": "1.0.0",
>     "linkCount": 2,
>     "connectionCount": 1,
>     "addrCount": 4,
>     "deliveriesEgressRouteContainer": 0,
>     "nodeCount": 0,
>     "modifiedDeliveries": 0,
>     "identity": "1",
>     "deliveriesEgress": 0,
>     "releasedDeliveries": 0,
>     "name": "Router.A",
>     "type": "org.apache.qpid.dispatch.router",
>     "deliveriesTransit": 0,
>     "mode": "standalone"
>   }
> ]
> {noformat}
>  
> The solution to this problem is to create a new entity called RouterStats and 
> move all the statistics related attributes to RouterStats. This RouterStats 
> entity will be handled by the C management agent.
>  
> The old Router entity which is currently handled by the C agent will be 
> handled by the Python agent instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to