[ 
https://issues.apache.org/jira/browse/DISPATCH-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393018#comment-16393018
 ] 

ASF GitHub Bot commented on DISPATCH-154:
-----------------------------------------

Github user orpiske commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/267#discussion_r173482946
  
    --- Diff: router/src/main.c ---
    @@ -176,6 +176,46 @@ static void daemon_process(const char *config_path, 
const char *python_pkgdir,
                 //
                 umask(0);
     
    +
    +            //
    +            // If config path is not represented by its full path, then
    +            // save current path before changing to /
    +            //
    +            char *config_path_full = NULL;
    +            if (strncmp("/", config_path, 1)) {
    +                char *cur_path = NULL;
    +                int path_size = 256;
    +                int getcwd_error = 0;
    +
    +                cur_path = (char *) malloc(path_size * sizeof(char));
    +                memset(cur_path, 0, path_size * sizeof(char));
    +
    --- End diff --
    
    I'd probably replace these w/ calloc, since the general behavior should be 
the same as per calloc spec.


> dispatch-router coredumps when connector address is unresolvable
> ----------------------------------------------------------------
>
>                 Key: DISPATCH-154
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-154
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Container
>            Reporter: Ted Ross
>            Assignee: Ted Ross
>            Priority: Major
>             Fix For: 0.5
>
>
> If the address of a connector is unresolvable, the router will crash upon 
> resolution failure.  This can be reproduced by adding the following 
> configuration:
> {noformat}
> connector {
>     addr: unres.bogus.unreg
>     port: amqp
>     role: on-demand
>     saslMechanisms: ANONYMOUS
>     name: bogus
> }
> linkRoutePattern {
>     prefix: abc
>     connector: bogus
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to