[
https://issues.apache.org/jira/browse/PROTON-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395031#comment-16395031
]
ASF GitHub Bot commented on PROTON-1638:
----------------------------------------
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton/pull/140
I gave things a skim over, changes seemed reasonable from my
doesnt-do-cmake-etc perspective.
Noting for later reference: this builds on / incorporates WIP from #136 and
#138.
> Need to improve proton-c build tree layout
> ------------------------------------------
>
> Key: PROTON-1638
> URL: https://issues.apache.org/jira/browse/PROTON-1638
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.18.0
> Reporter: Andrew Stitcher
> Assignee: Justin Ross
> Priority: Major
>
> The proton-c tree layout is annoying in a number of ways:
> * Since the split with proton-j there is a superfluous top level
> * CMake build flags don't propagate properly because examples are not in the
> correct subtree
> ** Examples should be in the binding subtree that they are examples
> ** Otherwise the information for a particular binding and its examples are
> split into 2 different parts of the proton-c tree.
> ** This means that the installation for a binding is split
> ** It is unatural in CMake to split build flags like this - CMake is
> hierarchical
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
