[
https://issues.apache.org/jira/browse/DISPATCH-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417306#comment-16417306
]
ASF GitHub Bot commented on DISPATCH-947:
-----------------------------------------
GitHub user mgoulish opened a pull request:
https://github.com/apache/qpid-dispatch/pull/273
DISPATCH-947 -- re-wrote first 9 Messenger tests to not use Messenger
First 9 Messenger tests now use reactor interface, and set self.error , etc.
I am doing a PR because I have never actually used the Messenger interface,
and in some cases it's not instantly obvious how to translate Messenger
concepts. It would be nice to have someone who is familiar take a quick look...
All remaining Messenger-based tests, I have just made to 'pass', so that
everything runs now. I will continue working on those.
Also, I renumbered all tests so they just go 1, 2, .... N
And gave numbers to the tests that had none.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgoulish/qpid-dispatch
de_messenger_one_router_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
----
> system tests on master branch failing when run against latest master proton
> ---------------------------------------------------------------------------
>
> Key: DISPATCH-947
> URL: https://issues.apache.org/jira/browse/DISPATCH-947
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.1.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> The system_tests_*.py are failing when run against the latest code from
> proton master branch with the following error
>
> {noformat}
> 42: Test command: /usr/bin/python
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-x" "unit2" "-v"
> "system_tests_http"
> 42: Test timeout computed to be: 1500
> 42: Traceback (most recent call last):
> 42: File "/usr/bin/unit2", line 11, in <module>
> 42: load_entry_point('unittest2==1.1.0', 'console_scripts', 'unit2')()
> 42: File "/usr/lib/python2.7/site-packages/unittest2/__main__.py", line 18,
> in main_
> 42: main(module=None)
> 42: File "/usr/lib/python2.7/site-packages/unittest2/main.py", line 89, in
> __init__
> 42: self.parseArgs(argv)
> 42: File "/usr/lib/python2.7/site-packages/unittest2/main.py", line 135, in
> parseArgs
> 42: self.createTests()
> 42: File "/usr/lib/python2.7/site-packages/unittest2/main.py", line 142, in
> createTests
> 42: self.module)
> 42: File "/usr/lib/python2.7/site-packages/unittest2/loader.py", line 245,
> in loadTestsFromNames
> 42: suites = [self.loadTestsFromName(name, module) for name in names]
> 42: File "/usr/lib/python2.7/site-packages/unittest2/loader.py", line 172,
> in loadTestsFromName
> 42: module = __import__(module_name)
> 42: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_http.py", line 23,
> in <module>
> 42: from system_test import TestCase, Qdrouterd, main_module, DIR
> 42: File "/home/gmurthy/opensource/qpid-dispatch/tests/system_test.py",
> line 478, in <module>
> 42: class Messenger(proton.Messenger):
> 42: AttributeError: 'module' object has no attribute 'Messenger'
> 42/42 Test #42: system_tests_http .........................***Failed 0.18
> sec
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
