[
https://issues.apache.org/jira/browse/QPIDJMS-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418516#comment-16418516
]
ASF GitHub Bot commented on QPIDJMS-374:
----------------------------------------
GitHub user mibo opened a pull request:
https://github.com/apache/qpid-jms/pull/17
QPIDJMS-374: Use getRawQuery to avoid double encoding
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mibo/qpid-jms master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-jms/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit b89a1e8cebcde65575aee1bd0dbe3c2cce01ccee
Author: mibo <mibo@...>
Date: 2018-03-29T06:52:29Z
QPIDJMS-374: Use getRawQuery to avoid double encoding
----
> Double encoded query parameters
> -------------------------------
>
> Key: QPIDJMS-374
> URL: https://issues.apache.org/jira/browse/QPIDJMS-374
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
> Affects Versions: 0.31.0
> Reporter: Michael Bolz
> Priority: Major
>
> When query parameters are parsed in
> [TransportFactory|https://github.com/apache/qpid-jms/blob/70fe1b882e1381b1016a10b0707f6e112d4e0598/qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportFactory.java#L51]
> and
> [AmqpProviderFactory|https://github.com/apache/qpid-jms/blob/70fe1b882e1381b1016a10b0707f6e112d4e0598/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProviderFactory.java#L41]
> and than further processed via
> [PropertyUtil#replaceQuery|https://github.com/apache/qpid-jms/blob/70fe1b882e1381b1016a10b0707f6e112d4e0598/qpid-jms-client/src/main/java/org/apache/qpid/jms/util/PropertyUtil.java#L64]
> the values gets double encoded.
> See also Javadoc of
> [PropertyUtil#replaceQuery|https://github.com/apache/qpid-jms/blob/70fe1b882e1381b1016a10b0707f6e112d4e0598/qpid-jms-client/src/main/java/org/apache/qpid/jms/util/PropertyUtil.java#L64]:
> {quote}
> The string values in the Map will be URL Encoded by this method which means
> that if an
> already encoded value is passed it will be double encoded resulting in
> corrupt values
> in the newly created URI.
> {quote}
> For a fix I created a [pull request|…].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
