[ 
https://issues.apache.org/jira/browse/QPIDJMS-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423736#comment-16423736
 ] 

Robbie Gemmell commented on QPIDJMS-373:
----------------------------------------

There isn't a way to add additional headers in the existing NettyWsTransport, 
as I say adding that seems reasonable.

The reason for suggesting the added ws prefix is that such options would be 
more tied to a specific transport (ws) than the TCP or SSL/TLS options that 
apply to everything that uses those respectively, and so it would be good to 
group them out for clarity.

The existing NettyWsTransport and NettyTcpTransport are themselves example of 
how you could add your own. Try following things from 
TransportFactory.findTransportFactory(String).

> Support for OAuth flow and setting of "Authorization" Header for WS upgrade 
> request
> -----------------------------------------------------------------------------------
>
>                 Key: QPIDJMS-373
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-373
>             Project: Qpid JMS
>          Issue Type: New Feature
>          Components: qpid-jms-client
>            Reporter: Michael Bolz
>            Priority: Major
>
> Add support for OAuth flow ("client_credentials" and "password") and setting 
> of "Authorization" Header during WebSocket connection handshake.
> Used "Authorization" Header or OAuth settings should/could be set via the 
> "transport" parameters (TransportOptions).
>  
> As PoC I created a [Fork|https://github.com/mibo/qpid-jms/tree/ws_add_header] 
> and have done one commit for the [add of the Authorization 
> Header|https://github.com/mibo/qpid-jms/commit/711052f0891556db0da6e7d68908b2f9dafadede]
>  and one commit for the [OAuth 
> flow|https://github.com/mibo/qpid-jms/commit/de70f0d3e4441358a239b3e776455201c133895d].
>  
> Hope this feature is not only interesting for me.
> If yes, I will add the currently missing tests to my contribution and do a 
> pull request.
>  
> Regards, Michael



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to