Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/279#discussion_r179510287
--- Diff: src/container.c ---
@@ -756,8 +756,16 @@ qd_link_t *qd_link(qd_node_t *node, qd_connection_t
*conn, qd_direction_t dir, c
sys_mutex_lock(node->container->lock);
DEQ_INSERT_TAIL(node->container->links, link);
sys_mutex_unlock(node->container->lock);
- link->pn_sess = pn_session(qd_connection_pn(conn));
- pn_session_set_incoming_capacity(link->pn_sess, cf->incoming_capacity);
+
+ bool open_session = false;
+
+ if (!conn->pn_sess) {
+ open_session = true;
--- End diff --
Why not just do pn_session_open() directly here? I don't see anything that
requires it to be delayed till the end.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
