[ https://issues.apache.org/jira/browse/PROTON-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432872#comment-16432872 ]
Andrew Stitcher commented on PROTON-1823: ----------------------------------------- [~aconway] You might want to consider adding a test to send a message long enough to make the buffer reallocate (noticed this is missing from the coverage run). > [c] make it easier to send a message > ------------------------------------ > > Key: PROTON-1823 > URL: https://issues.apache.org/jira/browse/PROTON-1823 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c > Affects Versions: proton-c-0.22.0 > Reporter: Alan Conway > Assignee: Alan Conway > Priority: Minor > Fix For: proton-c-0.23.0 > > > Encapsulates the awkward allocate-encode-expand dance required by > pn_message_encode() > Supports the following 2 scenarios: > 1. Simple: don't care about allocations, just send `pn_message_t *msg` and > forget it: > pn_message_send(msg, sender, NULL) > 2. Efficient: re-use a buffer, buffer is allocated and expanded as required: > pn_rwbytes_t buffer=\{0}; // Zero initialize, libary will do the > allocation > ... > pn_message_send(msg, sender, &buffer); // Expand as needed > pn_message_send(msg2, sender2, &buffer); // etc. > ... > free(buffer->start); // Application must do final free of buffer -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org