Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/294#discussion_r184679766
  
    --- Diff: src/amqp.c ---
    @@ -73,11 +76,30 @@ const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL = 
"amqp:frame-size-too-smal
     const char * const QD_AMQP_PORT_STR = "5672";
     const char * const QD_AMQPS_PORT_STR = "5671";
     
    +const char * const QD_AMQP_DFLT_PROTO = "tcp";
    +
     int qd_port_int(const char* port_str) {
         if (!strcmp(port_str, QD_AMQP_PORT_STR)) return QD_AMQP_PORT_INT;
    --- End diff --
    
    I understand that this is not part of the pull request, but aren't these 
lines (with strcmp) redundant with the strtoul below?  


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to