[
https://issues.apache.org/jira/browse/DISPATCH-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468675#comment-16468675
]
Robbie Gemmell edited comment on DISPATCH-989 at 5/9/18 11:07 AM:
------------------------------------------------------------------
This didn't really go the way I thought. So the files are still used (or would
have been if present), but whatever tool they are used by should be deprecated
and removed?
Given that noone noticed it was broken up to and including RC2 (I wasn't
actually trying to use whatever tool they are part of when I found the issue),
and you think it should be deprecated and removed, now seems to be the time to
do it? The broken pieces are part of the current 1.1.0 RC2, and a 1.1.0 RC3 is
about to be spun. Either we need to make this fix there and maybe also
deprecate (and then could remove them from master immediately if desired), or
the tool can just be deleted instead since we'd have otherwise decided it was
ok to leave it broken in the current release.
CC [~ganeshmurthy]
was (Author: gemmellr):
This didn't really go the way I thought. So the files are still used (or would
have been if present), but whatever tool they are used by should be deprecated
and removed?
Given that noone noticed it was broken up to and including RC2 (I wasn't
actually trying to use whatever tool they are part of when I found the issue),
and you think it should be deprecated and removed, now seems to be the time to
do it? The broken pieces are part of the current 1.1.0 RC2, and a 1.1.0 RC3 is
about to be spun. Either we need to make this fix there and maybe also
deprecate (and then could remove them from master immediately if desired), or
the tool can just be deleted instead since we'd have otherwise decided it was
ok to leave it broken.
CC [~ganeshmurthy]
> symlinks in tree to non existent files, possibly stale and could be removed?
> ----------------------------------------------------------------------------
>
> Key: DISPATCH-989
> URL: https://issues.apache.org/jira/browse/DISPATCH-989
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
> Affects Versions: 1.1.0
> Reporter: Robbie Gemmell
> Assignee: Ernest Allen
> Priority: Blocker
> Fix For: 1.1.0, 1.2.0
>
>
> There are a number of symlinks in the console tree which point to files that
> no longer exist. Its not clear these are actually required anymore, and may
> be stale and could be removed? The targets were seemingly removed by
> DISPATCH-917
> Dir console/test/css/:
> brokers.ttf -> ../../stand-alone/plugin/css/brokers.ttf
> dispatch.css -> ../../stand-alone/plugin/css/dispatch.css
> plugin.css -> ../../stand-alone/plugin/css/plugin.css
> site-base.css -> ../../stand-alone/plugin/css/site-base.css
> Dir console/test/html/:
> qdrConnect.html -> ../../stand-alone/plugin/html/qdrConnect.html
> qdrLayout.html -> ../../stand-alone/plugin/html/qdrLayout.html
> Dir console/test/js/:
> qdrService.js -> ../../stand-alone/plugin/js/qdrService.js
> Dir console/test/lib/:
> rhea-min.js -> ../../stand-alone/plugin/lib/rhea-min.js
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
