Having trouble loggingn into reviewboard I'm not sure if this is correct. If the link is not PN_LOCAL_CLOSED, then the application is well within its rights to close() it. If we have re-used it for another link that could close the wrong link.
This would be the 3rd time we've changed this particular line of code in the last few months, each time we find some new situation that fails. I'm inclined to think we should never re-use a "dead" link, and instead find out why proton is leaving these "dead" links lying around and fix that. On Tue, May 15, 2018 at 3:02 PM, Gordon Sim <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67139/ > Review request for qpid, Alan Conway, Ganesh Murthy, Justin Ross, and Ted > Ross. > By Gordon Sim. > *Bugs: * PROTON-1845 <https://issues.apache.org/jira/browse/PROTON-1845> > *Repository: * qpid-proton-git > Description > > If a peer sends attach, detach, attach with the same link name in the second > attach, the PN_LINK_REMOTE_OPEN event contains a reference to the link from > the first attach. This link is not in a state where it can be reused. > > It would be better to treat this as starting a new link object. > > This fixes DISPATCH-994 and DISPATCH-997 > > Diffs > > - c/src/core/transport.c (e0a2b5c) > > View Diff <https://reviews.apache.org/r/67139/diff/1/> >
