[
https://issues.apache.org/jira/browse/DISPATCH-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511553#comment-16511553
]
ASF GitHub Bot commented on DISPATCH-1037:
------------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/325
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=h1)
Report
> Merging
[#325](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/e6864f63e7086b1fee0063ff22803cae1fc14a35?src=pr&el=desc)
will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 86.54% 86.56% +0.02%
==========================================
Files 69 69
Lines 15460 15462 +2
==========================================
+ Hits 13380 13385 +5
+ Misses 2080 2077 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.21% <0%> (-0.58%)` | :arrow_down: |
|
[src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=)
| `82.72% <0%> (-0.31%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `85.83% <0%> (-0.28%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `86.6% <0%> (-0.2%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `85.85% <0%> (-0.19%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.57% <0%> (+0.14%)` | :arrow_up: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `71.54% <0%> (+0.14%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `95.24% <0%> (+0.23%)` | :arrow_up: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `99.25% <0%> (+0.37%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `90.73% <0%> (+0.62%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=footer).
Last update
[e6864f6...8276d91](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Listeners with http enabled are not being shutdown after they are deleted
> -------------------------------------------------------------------------
>
> Key: DISPATCH-1037
> URL: https://issues.apache.org/jira/browse/DISPATCH-1037
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine
> Reporter: Fernando Giorgetti
> Assignee: Ganesh Murthy
> Priority: Major
>
> When an http enabled listener is deleted through the console, or via qdmanage
> ($management), it is being removed from the list of listeners (qdmanage
> query) but the router still listens to the related TCP port.
> In the example below I had a router with an http listener on port 5674 and a
> non-http listener at 5672.
> Here are the steps to demonstrate it:
> * Start the router and query listeners
>
> {code:java}
> $ qdmanage query --type listener | egrep 'name'
> "name": "listener/0.0.0.0:5672",
> "name": "listener/0.0.0.0:5674",
> {code}
>
> * Verify TCP ports being listened
>
> {code:java}
> $ netstat -anp | egrep tcp.*LISTEN.*qdrouterd
> tcp 0 0 0.0.0.0:5672 0.0.0.0:* LISTEN 2887/qdrouterd
> tcp 0 0 0.0.0.0:5674 0.0.0.0:* LISTEN 2887/qdrouterd
> {code}
>
> * Delete HTTP listener on port 5674
>
> {code:java}
> $ qdmanage delete --type listener --name 'listener/0.0.0.0:5674'
> {code}
>
> * Query listeners
>
> {code:java}
> $ qdmanage query --type listener | egrep 'name'
> "name": "listener/0.0.0.0:5672",
> {code}
>
> * Verify TCP ports being listened
>
> {code:java}
> $ netstat -anp | egrep tcp.*LISTEN.*qdrouterd
> tcp 0 0 0.0.0.0:5672 0.0.0.0:* LISTEN 2887/qdrouterd
> tcp 0 0 0.0.0.0:5674 0.0.0.0:* LISTEN 2887/qdrouterd
> {code}
>
> Note: This is only happening with http enabled listeners. Regular listeners
> are being shutdown properly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
