-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/
-----------------------------------------------------------

(Updated June 18, 2018, 9:37 p.m.)


Review request for qpid and Ted Ross.


Changes
-------

Fix to ensure that the two new options can be used together (effectively 
modifying the address)


Bugs: DISPATCH-980
    https://issues.apache.org/jira/browse/DISPATCH-980


Repository: qpid-dispatch


Description
-------

This adds two fields to the link route config, addExternalPrefix and 
delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. 
they will cause a prefix to be inserted and/or deleted in the final hop for a 
link routed link attach. That prefix will also be stripped off or inserted back 
into the reply, making the renaming completely transparent to clients.


Diffs (updated)
-----

  include/qpid/dispatch/router_core.h 8f144b0 
  python/qpid_dispatch/management/qdrouter.json 42f501f 
  src/router_config.c 94758df 
  src/router_core/agent_config_link_route.h 57f6f0d 
  src/router_core/agent_config_link_route.c 981d142 
  src/router_core/connections.c 5fdc3bf 
  src/router_core/forwarder.c fca19c3 
  src/router_core/route_control.h 3c715bc 
  src/router_core/route_control.c 61f426d 
  src/router_core/router_core.c 9d7f7a5 
  src/router_core/router_core_private.h cd2ffa4 
  src/router_core/terminus.c 4c0e0a3 
  tests/CMakeLists.txt 159521d 
  tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION 


Diff: https://reviews.apache.org/r/66839/diff/3/

Changes: https://reviews.apache.org/r/66839/diff/2-3/


Testing
-------

Added system tests plus some ad hoc testing.


Thanks,

Gordon Sim

Reply via email to