GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-dispatch/pull/326
Logging
Some minor changes to dispatch logging based on experience debugging the
HTTP Envoy bridge.
See the commit comments for explanation.
One additional question: I was confused by the new messageLoggingComponents
config, when I set MESSAGE enable trace+ I saw nothing at all, which was
surprising. Perhaps the default should be "all" so that enabling MESSAGE trace
does what folks expect and they can turn the logging down per
connector/listener if they wish. Since trace logging will be off in production
(I hope!) this won't have any effect except on users that are deliberately
debugging AND have turned on trace logging for at least the MESSAGE module, so
are expecting a lot of log data.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alanconway/dispatch logging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #326
----
commit c2be6c7ec46567675a036c7c77ec840d3c2a4982
Author: Alan Conway <aconway@...>
Date: 2018-06-20T17:27:23Z
NO-JIRA: Adjust log levels.
- upgrade connection failure INFO messages to WARNING
- downgrade incref/decref messages to TRACE
Personally I think the incref/decref messages should not be in user-facing
logs
at all, but if they must be they should be TRACE as they occur at a
per-delivery
(i.e. per-message) volume.
commit d02442ec6422bbdb2cb505345eaa4afa2691068e
Author: Alan Conway <aconway@...>
Date: 2018-06-20T17:52:09Z
NO-JIRA: Removed redundant "accepted" log message, added missing
connection_id
commit d92719aad8f3be6ace7fb10dbadb9dcd4f1776b7
Author: Alan Conway <aconway@...>
Date: 2018-06-21T13:19:23Z
NO-JIRA: symmetric logging for incoming/outgoing establish/close connection
Incoming connection establishment was being logged at info.
Added info logs for outgoing connection establishment and any connection
close.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
