[
https://issues.apache.org/jira/browse/DISPATCH-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520743#comment-16520743
]
ASF GitHub Bot commented on DISPATCH-1045:
------------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/328
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/328?src=pr&el=h1)
Report
> Merging
[#328](https://codecov.io/gh/apache/qpid-dispatch/pull/328?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/2e766f35cf2b3a172aaa58cef6c996376e69f1c9?src=pr&el=desc)
will **increase** coverage by `0.1%`.
> The diff coverage is `92.85%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/328?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
=========================================
+ Coverage 86.52% 86.63% +0.1%
=========================================
Files 69 69
Lines 15479 15494 +15
=========================================
+ Hits 13393 13423 +30
+ Misses 2086 2071 -15
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/328?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/328/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.49% <100%> (+0.06%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/328/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `89.96% <80%> (-0.05%)` | :arrow_down: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/328/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `99.25% <0%> (+0.37%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/328/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.79% <0%> (+0.57%)` | :arrow_up: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/328/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `87.34% <0%> (+1.48%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/328?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/328?src=pr&el=footer).
Last update
[2e766f3...e40858d](https://codecov.io/gh/apache/qpid-dispatch/pull/328?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Sometimes close connetion after releasing partial multi-frame messsage
> ----------------------------------------------------------------------
>
> Key: DISPATCH-1045
> URL: https://issues.apache.org/jira/browse/DISPATCH-1045
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.1.0
> Reporter: Alan Conway
> Assignee: Ganesh Murthy
> Priority: Major
>
> Since DISPATCH-1012 the router releases undeliverable deliveries.
> In the case of a multi-frame delivery, it is possible for dispatch to release
> it before the entire delivery has been received. Presently dispatch settles
> such deliveries and advances its link. That means that if another transfer
> for the same delivery arrives, dispatch regards it as a new message with an
> invalid delivery-id and closes the connection. Since the release is
> asynchronous, there's no way for the client to avoid this possibility.
> Worth checking the spec but I suspect we should be dropping the extra data
> rather than closing the connection. Need to investigate how this would work
> in proton - I think we'd update the delivery without settling it and then
> wait for the remote to settle before finally throwing it away.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
