[
https://issues.apache.org/jira/browse/DISPATCH-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521283#comment-16521283
]
ASF GitHub Bot commented on DISPATCH-1047:
------------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/329
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/329?src=pr&el=h1)
Report
> Merging
[#329](https://codecov.io/gh/apache/qpid-dispatch/pull/329?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/2e766f35cf2b3a172aaa58cef6c996376e69f1c9?src=pr&el=desc)
will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 86.52% 86.56% +0.03%
==========================================
Files 69 69
Lines 15479 15479
==========================================
+ Hits 13393 13399 +6
+ Misses 2086 2080 -6
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/329?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/329/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.57% <0%> (+0.14%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/329/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `95.24% <0%> (+0.23%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/329/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `90.48% <0%> (+0.46%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/329?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/329?src=pr&el=footer).
Last update
[2e766f3...aeb5d5f](https://codecov.io/gh/apache/qpid-dispatch/pull/329?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> system_tests_ssl fail when running under python3 environment
> ------------------------------------------------------------
>
> Key: DISPATCH-1047
> URL: https://issues.apache.org/jira/browse/DISPATCH-1047
> Project: Qpid Dispatch
> Issue Type: Bug
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Attachments: Dockerfile-ctest
>
>
> Can be reproduced in attached dockerfile
> ------
> Start 45: system_tests_ssl
> 45: Test command: /usr/bin/python
> "/main/qpid-dispatch-master/BUILD/tests/run.py" "-x" "unit2" "-v"
> "system_tests_ssl"
> 45: Test timeout computed to be: 1500
> 45: ERROR
> 45: ERROR
> 45:
> 45: ======================================================================
> 45: ERROR: setUpClass (system_tests_ssl.RouterTestSslClient)
> 45: ----------------------------------------------------------------------
> 45: Traceback (most recent call last):
> 45: File "/main/qpid-dispatch-master/tests/system_tests_ssl.py", line 105,
> in setUpClass
> 45: super(RouterTestSslClient, cls).create_sasl_files()
> 45: File "/main/qpid-dispatch-master/tests/system_tests_ssl.py", line 57,
> in create_sasl_files
> 45: result = pipe.communicate('password')
> 45: File "/usr/lib64/python3.6/subprocess.py", line 843, in communicate
> 45: stdout, stderr = self._communicate(input, endtime, timeout)
> 45: File "/usr/lib64/python3.6/subprocess.py", line 1499, in _communicate
> 45: input_view = memoryview(self._input)
> 45: TypeError: memoryview: a bytes-like object is required, not 'str'
> 45:
> 45: ======================================================================
> 45: ERROR: setUpClass (system_tests_ssl.RouterTestSslInterRouter)
> 45: ----------------------------------------------------------------------
> 45: Traceback (most recent call last):
> 45: File "/main/qpid-dispatch-master/tests/system_tests_ssl.py", line 410,
> in setUpClass
> 45: super(RouterTestSslInterRouter, cls).create_sasl_files()
> 45: File "/main/qpid-dispatch-master/tests/system_tests_ssl.py", line 57,
> in create_sasl_files
> 45: result = pipe.communicate('password')
> 45: File "/usr/lib64/python3.6/subprocess.py", line 843, in communicate
> 45: stdout, stderr = self._communicate(input, endtime, timeout)
> 45: File "/usr/lib64/python3.6/subprocess.py", line 1499, in _communicate
> 45: input_view = memoryview(self._input)
> 45: TypeError: memoryview: a bytes-like object is required, not 'str'
> 45:
> 45: ----------------------------------------------------------------------
> 45: Ran 0 tests in 0.005s
> 45:
> 45: FAILED (errors=2)
> 45/47 Test #45: system_tests_ssl ..................................***Failed
> 0.22
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
