[
https://issues.apache.org/jira/browse/DISPATCH-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565985#comment-16565985
]
ASF GitHub Bot commented on DISPATCH-1093:
------------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/350
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/350?src=pr&el=h1)
Report
> Merging
[#350](https://codecov.io/gh/apache/qpid-dispatch/pull/350?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/7285a47dcdd255af5ecc8d9c95fe8bdd28fb981d?src=pr&el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/350?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #350 +/- ##
=========================================
- Coverage 84.32% 84.3% -0.02%
=========================================
Files 69 69
Lines 15670 15676 +6
=========================================
+ Hits 13214 13216 +2
- Misses 2456 2460 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/350?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/350/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j)
| `75.05% <100%> (+0.15%)` | :arrow_up: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/350/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `84.35% <100%> (ø)` | :arrow_up: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/350/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `98.89% <0%> (-0.37%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/350/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `85.83% <0%> (-0.24%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/350/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `87.44% <0%> (-0.19%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/350?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/350?src=pr&el=footer).
Last update
[7285a47...1f806ab](https://codecov.io/gh/apache/qpid-dispatch/pull/350?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> adding connectors dynamically causes extra connections for existing connectors
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-1093
> URL: https://issues.apache.org/jira/browse/DISPATCH-1093
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Gordon Sim
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.3.0
>
>
> Every time a new connector is created dynamically, the router will create a
> new connection for any existing connector. E.g. with some amqp server
> listening on ports 5673 and 5674:
> {noformat}
> $ echo '{"host":"localhost","port":5673}' | qdmanage CREATE --type=connector
> --name=foo --stdin
> {
> "verifyHostname": true,
> "stripAnnotations": "both",
> "name": "foo",
> "idleTimeoutSeconds": 16,
> "allowRedirect": true,
> "messageLoggingComponents": "none",
> "maxFrameSize": 16384,
> "host": "localhost",
> "cost": 1,
> "role": "normal",
> "failoverUrls": "amqp://localhost:5673",
> "maxSessions": 32768,
> "type": "org.apache.qpid.dispatch.connector",
> "port": "5673",
> "identity": "connector/localhost:5673:foo"
> }
> ]$ qdstat -c
> Connections
> id host container role dir
> security authentication tenant
>
> =============================================================================================================
> 2 localhost:5673 a6022696-2483-49f5-8ea6-a6f50db0e7ae normal out
> no-security anonymous-user
> 3 127.0.0.1:56024 d964573c-297f-499c-a1f5-fed7d8e74f9c normal in
> no-security no-auth
> $ echo '{"host":"localhost","port":5674}' | qdmanage CREATE --type=connector
> --name=bar --stdin
> {
> "verifyHostname": true,
> "stripAnnotations": "both",
> "name": "bar",
> "idleTimeoutSeconds": 16,
> "allowRedirect": true,
> "messageLoggingComponents": "none",
> "maxFrameSize": 16384,
> "host": "localhost",
> "cost": 1,
> "role": "normal",
> "failoverUrls": "amqp://localhost:5674",
> "maxSessions": 32768,
> "type": "org.apache.qpid.dispatch.connector",
> "port": "5674",
> "identity": "connector/localhost:5674:bar"
> }
> $ qdstat -c
> Connections
> id host container role dir
> security authentication tenant
>
> =============================================================================================================
> 2 localhost:5673 a6022696-2483-49f5-8ea6-a6f50db0e7ae normal out
> no-security anonymous-user
> 6 localhost:5673 a6022696-2483-49f5-8ea6-a6f50db0e7ae normal out
> no-security anonymous-user
> 5 localhost:5674 48fefab4-7df0-5244-b491-ad85278b22dc normal out
> no-security anonymous-user
> 7 127.0.0.1:56074 c4ddfd00-2ef5-473f-9687-28ee4bae4def normal in
> no-security no-auth
> $ echo '{"host":"localhost","port":5675}' | qdmanage CREATE --type=connector
> --name=baz --stdin
> {
> "verifyHostname": true,
> "stripAnnotations": "both",
> "name": "baz",
> "idleTimeoutSeconds": 16,
> "allowRedirect": true,
> "messageLoggingComponents": "none",
> "maxFrameSize": 16384,
> "host": "localhost",
> "cost": 1,
> "role": "normal",
> "failoverUrls": "amqp://localhost:5675",
> "maxSessions": 32768,
> "type": "org.apache.qpid.dispatch.connector",
> "port": "5675",
> "identity": "connector/localhost:5675:baz"
> }
> $ qdstat -c
> Connections
> id host container role dir
> security authentication tenant
>
> =============================================================================================================
> 2 localhost:5673 a6022696-2483-49f5-8ea6-a6f50db0e7ae normal out
> no-security anonymous-user
> 6 localhost:5673 a6022696-2483-49f5-8ea6-a6f50db0e7ae normal out
> no-security anonymous-user
> 5 localhost:5674 48fefab4-7df0-5244-b491-ad85278b22dc normal out
> no-security anonymous-user
> 11 localhost:5673 a6022696-2483-49f5-8ea6-a6f50db0e7ae normal out
> no-security anonymous-user
> 10 localhost:5674 48fefab4-7df0-5244-b491-ad85278b22dc normal out
> no-security anonymous-user
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
