[
https://issues.apache.org/jira/browse/DISPATCH-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575313#comment-16575313
]
ASF GitHub Bot commented on DISPATCH-1098:
------------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/355
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=h1)
Report
> Merging
[#355](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/ba87373735d69fe28e8c77169b5a4e5b9bf278f5?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
- Coverage 84.48% 84.47% -0.01%
==========================================
Files 69 69
Lines 15730 15730
==========================================
- Hits 13289 13288 -1
- Misses 2441 2442 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `98.89% <0%> (-0.37%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `86.6% <0%> (-0.23%)` | :arrow_down: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `76.55% <0%> (-0.2%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `95.31% <0%> (+0.11%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.51% <0%> (+0.13%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=footer).
Last update
[ba87373...fdefed6](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Fedora 28 python3-only test issues
> ----------------------------------
>
> Key: DISPATCH-1098
> URL: https://issues.apache.org/jira/browse/DISPATCH-1098
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.2.0
> Reporter: Chuck Rolke
> Priority: Major
> Attachments: Dockerfile-DISPATCH-1098, build-1098.sh, run-1098.sh
>
>
> Building a Fedora 28, python-3-only (no python 2), proton and dispatch leads
> to some test issues.
> * `which python` is empty
> * `which unit2` is empty
> h4. Define python
> CMake finds python OK and builds proton and dispatch with the correct python
> version. But the tests don't work. _python_ appears to be a python 2
> construct. In a python 3 system the executable is installed as python3.
> Python can be defined with the alternatives command
> {{alternatives --install /usr/bin/python python /usr/bin/python3 1}}
> h4. Define unit2
> The self test runner in dispatch expects an executable named _unit2_. _Unit2_
> is a python 2 executable and in python 3 the equivalent program is named
> _unit2-3_. The dispatch build scheme should always use _unit2_ and thiis can
> be accomplished for python 3 with:
> {{alternatives --install /usr/bin/unit2 unit2 /usr/bin/unit2-3 1}}
> h4. Proposal
> Dispatch self test should use naked _python_ and _unit2_ commands. An check
> in the dispatch build could disable tests and warn about them being disabled
> similar to how a missing unittest2 is handled. See
> https://issues.apache.org/jira/browse/DISPATCH-919
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
