Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/366#discussion_r212715250
  
    --- Diff: src/router_core/connections.c ---
    @@ -1329,6 +1329,9 @@ static void qdr_connection_closed_CT(qdr_core_t 
*core, qdr_action_t *action, boo
         while (link_ref) {
             qdr_link_t *link = link_ref->link;
     
    +        if (link->auto_link && link->auto_link->retry_timer)
    +            qdr_core_timer_cancel_CT(core, link->auto_link->retry_timer);
    --- End diff --
    
    The fact that there is a retry-timer in the auto-link is an implementation 
detail that should not be visible at this level.  It would be better to have a 
call in the route_control module for "auto_link_connection_closed" or similar.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to