[
https://issues.apache.org/jira/browse/QPID-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8243:
-----------------------------
Status: Reviewable (was: In Progress)
> [Broker-J] Optimize logback turbo filter implemented to provide a workaround
> for Logback1027
> --------------------------------------------------------------------------------------------
>
> Key: QPID-8243
> URL: https://issues.apache.org/jira/browse/QPID-8243
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-7.0.6
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Whilst investigating a performance issue reported as part of QPID-8238 I ran
> a java profiler which had detected some performance loss on invocations of
> {{Logback1027WorkaroundTurboFilter}} due to creation of {{IdentityHashMap}}
> which is only required when {{Throwable}} is logged. In many cases when
> string messages are logged the creation of {{IdentityHashMap}} is redundant.
> It waists CPU resource and creates extra work for GC.
> I committed some changes
> [https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c30e8ae] to
> create {{IdentityHashMap}} only when {{Throwable}} is supplied.
> Following [review comments from Keith
> Wall|https://issues.apache.org/jira/browse/QPID-8238?focusedCommentId=16610224&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16610224],
> I raised this JIRA to track {{Logback1027WorkaroundTurboFilter}} changes and
> reapply the commit
> [c30e8ae|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c30e8ae].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
