Github user kgiusti commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/393#discussion_r226743048
--- Diff: include/qpid/dispatch/router_core.h ---
@@ -721,10 +723,11 @@ typedef struct qdr_query_t qdr_query_t;
* @param name The name supplied for the entity
* @param in_body The body of the request message
* @param out_body A composed field for the body of the response message
+ * @param in_conn The identity of the connection over which the mgmt
message arrived (0 if config file)
*/
void qdr_manage_create(qdr_core_t *core, void *context,
qd_router_entity_type_t type,
qd_iterator_t *name, qd_parsed_field_t *in_body,
qd_composed_field_t *out_body,
- qd_buffer_list_t body_buffers);
+ qd_buffer_list_t body_buffers, uint64_t in_conn);
--- End diff --
I think that may introduce a timing window. Is it possible that the
connection can be removed before the core gets the processing the create
request?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
