[GitHub] qpid-jms pull request #23: onConnectionEstablished(): log only main broker U...

[benoitdevos]

GitHub user benoitdevos opened a pull request:

    https://github.com/apache/qpid-jms/pull/23

    onConnectionEstablished(): log only main broker URI part.

    This commit changes a little bit the logging info in the 
onConnectionEstablished() method. URI query params do not need to be logged.
    
    **Context**
    The broker URI may contain sensitive info (like path to trust / key stores, 
and related **passwords**), and this info is being logged.
    
    _Sample_:
    ```
    <bean id="jmsConnectionFactory" 
class="org.apache.qpid.jms.JmsConnectionFactory">
        <constructor-arg name="remoteURI" value="amqps://some-location:5671?
    transport.keyStoreLocation=/very/long/path/nnn-openssl.p12&amp;
    transport.keyStorePassword=*******&amp;
    transport.trustStoreLocation=/very/long/path/server.keystore&amp;
    transport.trustStorePassword=*******"/>
    </bean>
    ```
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benoitdevos/qpid-jms master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-jms/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit ec2559906880ba1369a15b92b00c3d5482166a00
Author: Benoit Devos <benoit.devos@...>
Date:   2018-10-25T15:25:01Z

    onConnectionEstablished(): log only main broker URI part.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org