[
https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668743#comment-16668743
]
ASF GitHub Bot commented on DISPATCH-1155:
------------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/409
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=h1)
Report
> Merging
[#409](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/fcf457c981c262d5648d6c1a944059a3c3b47458?src=pr&el=desc)
will **increase** coverage by `0.02%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 85.16% 85.19% +0.02%
==========================================
Files 78 78
Lines 17429 17430 +1
==========================================
+ Hits 14843 14849 +6
+ Misses 2586 2581 -5
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j)
| `76.44% <66.66%> (-0.11%)` | :arrow_down: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.8% <0%> (-0.26%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.65% <0%> (ø)` | :arrow_up: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `93.66% <0%> (+0.21%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `95.48% <0%> (+0.21%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `90.31% <0%> (+0.44%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.84% <0%> (+0.56%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=footer).
Last update
[fcf457c...61564b9](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> dueling httpRootDirs
> --------------------
>
> Key: DISPATCH-1155
> URL: https://issues.apache.org/jira/browse/DISPATCH-1155
> Project: Qpid Dispatch
> Issue Type: Bug
> Reporter: michael goulish
> Assignee: michael goulish
> Priority: Major
>
> New version of qpid-dispatch-router uses
> "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir.
> But when installing new qpid-dispatch-console package, the pages are
> available at "/usr/share/qpid-dispatch/console".
> This forces the user to define httpRootDir on the listener to bypass this
> issue.
> Ted suggests this fix:
>
> Remove the default behavior for httpRootDir. If it is not specified in the
> configuration for a listener, then HTTP requests shall be rejected on
> connections to that listener. Such a listener would only be usable for AMQP
> over websockets.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
