Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/169
__I 100% support having a consistent automated format for the proton
codebase(s)__
However , I don't think this is quite it (IMO):
- I think we should just leave the proton-c codebase with an indent of 2 -
A lot of changes for marginal gain there.
- We can have a 4 space indent for the C++ code, I don't think having
slightly different settings is a problem if the format is automatically applied.
- I think we can allow wider lines - it looks like it is wrapping at 80
chars, I think 100 would be fine (conservative even) for modern screens.
- I'm not happy with the reformatting of the header files:
- Especially reformatting the 2nd and subsequent parameter at a variable
indent - not cool for variable width fonts!.
- Seems to have reformatted blah* x(); to blah *x(); which is fine for C
code, but not for C++ code. Another area where the setting should probably be
different.
- Connected to the first sub point: if the function name and first
parameter is too long wrapping both:
blah *pn_xxxx(pn_param1 *x);
To
blah *
pn_xxxx(pn_param1 *x);
I think the mess of the header files is actually the most important issue
given that this is user visible documentation. It should look as nice as we can
make it. Consistency is important, but it shouldn't be ugly to view - I
currently opine that the reformat has made the header files ugly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
