[
https://issues.apache.org/jira/browse/QPID-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737380#comment-16737380
]
ASF GitHub Bot commented on QPID-5285:
--------------------------------------
grs commented on pull request #20: QPID-5285 [AMQP 1.0] timestamped messages
not supported
URL: https://github.com/apache/qpid-cpp/pull/20#discussion_r246104594
##########
File path: src/qpid/broker/amqp/Incoming.cpp
##########
@@ -108,7 +109,11 @@ namespace {
}
DecodingIncoming::DecodingIncoming(pn_link_t* link, Broker& broker, Session&
parent, const std::string& source, const std::string& target, const
std::string& name)
- : Incoming(link, broker, parent, source, target, name),
sessionPtr(parent.shared_from_this()) {}
Review comment:
Might be nicer to set in initialiser for consistency (could then also make
the attribute a const)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [AMQP 1.0] timestamped messages not supported
> ---------------------------------------------
>
> Key: QPID-5285
> URL: https://issues.apache.org/jira/browse/QPID-5285
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: 0.24
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Major
> Fix For: Future
>
> Attachments: Incoming.cpp
>
>
> There is a timestamping feature in qpidd that if enabled sets the timestamp
> field of the AMQP 0-10 delivery-properties when a message arrives at the
> broker.
> There is no equivalent field defined in the AMQP 1.0 specification. Thus this
> feature is at present not supported over 1.0 (i.e. messages delivered over
> 1.0 will not have the timestamp set).
> An annotation could be defined to convey the timestamp for 1.0 messages. This
> could also be used in translating between 0-10 and 1.0 formats.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
