[
https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739486#comment-16739486
]
ASF GitHub Bot commented on DISPATCH-1237:
------------------------------------------
codecov-io commented on issue #436: DISPATCH-1237 - Modified link cleanup code
to not release a multicast…
URL: https://github.com/apache/qpid-dispatch/pull/436#issuecomment-451772267
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr&el=h1)
Report
> Merging
[#436](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/85847d62f694c0717c5db32c60aaa80bf7940ab2?src=pr&el=desc)
will **increase** coverage by `0.07%`.
> The diff coverage is `90%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 86.93% 87.01% +0.07%
==========================================
Files 85 85
Lines 18700 18716 +16
==========================================
+ Hits 16257 16285 +28
+ Misses 2443 2431 -12
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `91.06% <100%> (+0.77%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `95.15% <83.33%> (+0.03%)` | :arrow_up: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `88.84% <90%> (-0.02%)` | :arrow_down: |
|
[src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=)
| `83.52% <0%> (+0.28%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `64.4% <0%> (+0.56%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.92% <0%> (+0.7%)` | :arrow_up: |
|
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
| `93.61% <0%> (+0.95%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr&el=footer).
Last update
[85847d6...963c3b4](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> large frame multicast can stall receivers if one receiver closes its
> connection
> -------------------------------------------------------------------------------
>
> Key: DISPATCH-1237
> URL: https://issues.apache.org/jira/browse/DISPATCH-1237
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Environment: The attached patch updates the edge router test to
> reproduce this issue.
> NOTE WELL - you must have the fix for DISPATCH-1235 applied before running
> this test else the router will crash.
> Reporter: Ken Giusti
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.5.0
>
> Attachments: test.patch
>
>
> Ran the following scenario on an edge router:
> 1 sender (not presettled)
> 3 receivers
> multicast
> large message
> If I have one of the receivers close its connection while in the middle of a
> multi frame transfer the router marks the message as "discard" and does not
> forward the remaining frames to the two remaining clients, thus stalling
> their links.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
