[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784580#comment-16784580
]
ASF subversion and git services commented on DISPATCH-1268:
-----------------------------------------------------------
Commit 7987437dbe321a0a604767d39e8c13b180278860 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7987437 ]
DISPATCH-1268 - Use a "Generator expression" to get .so file name
> Use more modern idiomatic cmake
> -------------------------------
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Jiri Daněk
> Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
