[
https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786081#comment-16786081
]
ASF GitHub Bot commented on DISPATCH-1275:
------------------------------------------
ted-ross commented on pull request #455: DISPATCH-1275 - Enabled deletion of
connections based on connection i…
URL: https://github.com/apache/qpid-dispatch/pull/455#discussion_r263110299
##########
File path: src/router_core/agent.c
##########
@@ -414,7 +414,7 @@ static void qdr_manage_delete_CT(qdr_core_t *core,
qdr_action_t *action, bool di
case QD_ROUTER_CONFIG_ADDRESS: qdra_config_address_delete_CT(core,
query, name, identity); break;
case QD_ROUTER_CONFIG_LINK_ROUTE: qdra_config_link_route_delete_CT(core,
query, name, identity); break;
case QD_ROUTER_CONFIG_AUTO_LINK: qdra_config_auto_link_delete_CT(core,
query, name, identity); break;
- case QD_ROUTER_CONNECTION: break;
+ case QD_ROUTER_CONNECTION: qdra_connection_delete_CT(core, query,
identity); break; //Connection objects are created by the router and they have
an id and no name
Review comment:
The forced closing of a connection is supposed to be signalled by setting
the adminStatus to "deleted", not by using the DELETE method in AMQP management.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable deletion of connections based on connection id
> -----------------------------------------------------
>
> Key: DISPATCH-1275
> URL: https://issues.apache.org/jira/browse/DISPATCH-1275
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.5.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> Sometimes there is a need to delete/kill certain connections on which there
> are slow consumers or consumers that won't acknowledge messages.
> Add functionality to the router server side code that will allow users to
> delete connections based on the connection id. The connection id can be
> obtained from the output of--
> {noformat}
> qdstat -c{noformat}
> or
> {noformat}
> qdmanage QUERY --type=connection{noformat}
> This JIRA involves the following tasks
> # Add two fields, adminStatus and operStatus to the *connection* entity in
> the router schema. Possible connection adminStatues are *enabled* and
> *deleted.* Possible operStatuses are *up*
> # Modify the router's c-management agent to respond to a DELETE management
> request. A connection id must be provided to delete a connection. When a
> client deletes a connection object, the connection to the peer is terminated
> by the router. Client will not be allowed to terminate inter-router
> connections.
> # Add policy control over who is permitted to write adminStatus (add a new
> flag at the policy group level called allowAdminStatusUpdate)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
