[ 
https://issues.apache.org/jira/browse/DISPATCH-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793219#comment-16793219
 ] 

ASF GitHub Bot commented on DISPATCH-1287:
------------------------------------------

codecov-io commented on issue #466: DISPATCH-1287: when sender has indicated 
credit is drained...
URL: https://github.com/apache/qpid-dispatch/pull/466#issuecomment-473120932
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/466?src=pr&el=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@88e2589`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/466/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/466?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #466   +/-   ##
   =========================================
     Coverage          ?   86.69%           
   =========================================
     Files             ?       86           
     Lines             ?    18901           
     Branches          ?        0           
   =========================================
     Hits              ?    16387           
     Misses            ?     2514           
     Partials          ?        0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/466?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/466/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `90.65% <100%> (ø)` | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/466?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/466?src=pr&el=footer).
 Last update 
[88e2589...d13cf8c](https://codecov.io/gh/apache/qpid-dispatch/pull/466?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> router gets confused by clients response to drain and subsequently issue too 
> little credit
> ------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-1287
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1287
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Gordon Sim
>            Priority: Major
>             Fix For: 1.6.0
>
>         Attachments: drainable.py
>
>
> A sender is opened for an address on which there is a receiver. It sends one 
> messages which is accepted. The receiver then detaches and the sender tries 
> to send another message. This second message is released and the router 
> attempts to drain the senders credit.
> The sender responds to the drain request by not sending any further messages 
> but incrementing the delivery_count by the appropriate amount.
> If a receiver attaches on the address again after this point, the router 
> issues credit back to the sender, but only issues link-credit=1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to