[
https://issues.apache.org/jira/browse/DISPATCH-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799661#comment-16799661
]
ASF GitHub Bot commented on DISPATCH-1295:
------------------------------------------
codecov-io commented on issue #476: DISPATCH-1295 - Reduce lock contention and
make fewer system calls.
URL: https://github.com/apache/qpid-dispatch/pull/476#issuecomment-475874874
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/476?src=pr&el=h1)
Report
> Merging
[#476](https://codecov.io/gh/apache/qpid-dispatch/pull/476?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/106ba6cdc174232302692a9d9dfa7714e7ce6497?src=pr&el=desc)
will **increase** coverage by `0.12%`.
> The diff coverage is `89.83%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/476?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 86.97% 87.09% +0.12%
==========================================
Files 86 86
Lines 19281 19332 +51
==========================================
+ Hits 16770 16838 +68
+ Misses 2511 2494 -17
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/476?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/immediate.c](https://codecov.io/gh/apache/qpid-dispatch/pull/476/diff?src=pr&el=tree#diff-c3JjL2ltbWVkaWF0ZS5j)
| `81.15% <84.84%> (-16.28%)` | :arrow_down: |
|
[src/timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/476/diff?src=pr&el=tree#diff-c3JjL3RpbWVyLmM=)
| `94.4% <96.15%> (+0.16%)` | :arrow_up: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/476/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.9% <0%> (-0.26%)` | :arrow_down: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/476/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `79.77% <0%> (+0.18%)` | :arrow_up: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/476/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `87.09% <0%> (+0.21%)` | :arrow_up: |
|
[src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/476/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==)
| `87.96% <0%> (+3.7%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/476/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `81.88% <0%> (+5.21%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/476?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/476?src=pr&el=footer).
Last update
[106ba6c...7765a6a](https://codecov.io/gh/apache/qpid-dispatch/pull/476?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> reduce cpu and locking in timer/immediate code.
> -----------------------------------------------
>
> Key: DISPATCH-1295
> URL: https://issues.apache.org/jira/browse/DISPATCH-1295
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
> Affects Versions: 1.6.0
> Reporter: Cliff Jansen
> Priority: Major
>
> Follow on to DISPATCH-1274.
> Locks held for longer time than necessary (through system calls).
> Spurious calls to timer_visit() that should be restricted to
> immediate_visit().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
