[
https://issues.apache.org/jira/browse/QPID-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811065#comment-16811065
]
ASF GitHub Bot commented on QPID-8294:
--------------------------------------
alex-rufous commented on pull request #23: QPID-8294: [Broker-J][Oracle Message
Store] Batch delete fails for more than 1000 messages
URL: https://github.com/apache/qpid-broker-j/pull/23#discussion_r272668667
##########
File path:
broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/AbstractJDBCMessageStore.java
##########
@@ -82,6 +82,8 @@
private static final String XID_TABLE_NAME_SUFFIX = "QPID_XIDS";
private static final String XID_ACTIONS_TABLE_NAME_SUFFIX =
"QPID_XID_ACTIONS";
+ private static final int MAX_DELETE_BATCH_SIZE = 1000;
Review comment:
I think it would be beneficial to set maximum delete batch size using JVM
system variable in case if other RDBMS have a lower limit. Something like below
`private static final int MAX_DELETE_BATCH_SIZE =
Integer.getInteger("qpid.jdbcStoreMaxDeleteBatchSize",1000);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Broker-J][Oracle Message Store] Batch delete fails for more than 1000
> messages
> -------------------------------------------------------------------------------
>
> Key: QPID-8294
> URL: https://issues.apache.org/jira/browse/QPID-8294
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
> Affects Versions: qpid-java-broker-7.1.0
> Reporter: Olivier VERMEULEN
> Priority: Critical
>
> When under high load, the Broker-J can end up having to delete more than 1000
> messages in a single batch. But some databases (and Oracle in particular) put
> a limit to the number of elements you can have in the IN clause. So we end up
> with the following exception: ORA-01795: maximum number of expressions in a
> list is 1000
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
