[
https://issues.apache.org/jira/browse/DISPATCH-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820266#comment-16820266
]
ASF GitHub Bot commented on DISPATCH-1311:
------------------------------------------
codecov-io commented on issue #489: DISPATCH-1311: move qdr_delivery_t API to
its own source files
URL: https://github.com/apache/qpid-dispatch/pull/489#issuecomment-484162273
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/489?src=pr&el=h1)
Report
> Merging
[#489](https://codecov.io/gh/apache/qpid-dispatch/pull/489?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/9a1796ccd6186e57caff9564b6c215091f566007?src=pr&el=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `89%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/489?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 86.9% 86.94% +0.04%
==========================================
Files 86 87 +1
Lines 19245 19246 +1
==========================================
+ Hits 16724 16733 +9
+ Misses 2521 2513 -8
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/489?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.53% <ø> (ø)` | :arrow_up: |
|
[src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j)
| `97% <ø> (ø)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.49% <ø> (+0.37%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.01% <ø> (+3.03%)` | :arrow_up: |
|
[src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `91.94% <ø> (ø)` | :arrow_up: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `87.06% <ø> (-0.03%)` | :arrow_down: |
|
[src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=)
| `91.51% <ø> (ø)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.76% <100%> (ø)` | :arrow_up: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `88.88% <88.88%> (ø)` | |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `93.45% <0%> (-0.22%)` | :arrow_down: |
| ... and [3
more](https://codecov.io/gh/apache/qpid-dispatch/pull/489/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/489?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/489?src=pr&el=footer).
Last update
[9a1796c...076f0bf](https://codecov.io/gh/apache/qpid-dispatch/pull/489?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Move the qdr_delivery_t code to a dedicated file (reorganization)
> -----------------------------------------------------------------
>
> Key: DISPATCH-1311
> URL: https://issues.apache.org/jira/browse/DISPATCH-1311
> Project: Qpid Dispatch
> Issue Type: Sub-task
> Components: Router Node
> Affects Versions: 1.6.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Labels: delivery-refactor
>
> Let's start the process of moving delivery settlement and disposition
> handling out of the core thread by isolating the qdr_delivery_t handling
> code. This code is currently residing in the transfer.c source file which
> also contains various link and connection state handling. The qdr_delivery_t
> structure definition should also be moved out of the common router core
> private header file.
> This change will simply move delivery code to its own delivery.c and
> delivery.h in the router_core directory (for now). No functional changes
> will be made, though some method names may be changed for consistency.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
