[
https://issues.apache.org/jira/browse/PROTON-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831062#comment-16831062
]
ASF subversion and git services commented on PROTON-2029:
---------------------------------------------------------
Commit ad0a7debf47a4e7cdbcb97c3cf36d185c8863c18 in qpid-proton-j's branch
refs/heads/master from Timothy Bish
[ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=ad0a7de ]
PROTON-2029 Add fix and test for extraneous disposition after settle
Adds tests for disposition change after settled and a check for settled
state to circumvent more transport work being added when the delivery
has already been tagged as settled.
> applying delivery state to a locally-settled delivery can cause erroneous
> disposition frame
> -------------------------------------------------------------------------------------------
>
> Key: PROTON-2029
> URL: https://issues.apache.org/jira/browse/PROTON-2029
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: proton-j-0.32.0
> Reporter: Robbie Gemmell
> Priority: Minor
>
> If a delivery has disposition state applied and is locally-settled (and the
> transport output processed), e.g a consumer receiving an unsettled message
> and acknowledging it, then the unexpected act of applying further delivery
> state to the delivery object can result in erroneously emitting another
> disposition frame upon future processing.
> This occurs because applying the state makes adds the delivery to the
> transport work list again, with the process only being gated on prior
> remote-settlement to prevent sending a useless notice of settlement. It
> should also gate on local-settlement to avoid the odd post-settlement state
> application from actually leading to a disposition frame.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
