[
https://issues.apache.org/jira/browse/PROTON-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832567#comment-16832567
]
ASF GitHub Bot commented on PROTON-2040:
----------------------------------------
astitcher commented on issue #181: PROTON-2040 [cpp] Allow connection options
to be updated for reconnect
URL: https://github.com/apache/qpid-proton/pull/181#issuecomment-489131518
I don't think I like this design much.
If I understand it correctly when you get to the reconnect you can't modify
the connection options but only overwrite them completely.
This means that you have to keep around the original connection options and
then update them with any changes. This is IMO inconvenient, but worse isn't
what the API seems to offer with the name `reconnect_update()` - even if the
comment is correct.
I think it would it be better for the connection to keep around the
connection options used and then you could really update them. If we implement
it this way we could offer a more general `connection::connection_options()`
accessor and allow that to be updated with the existing
`connection_options::update()` API and not need the `reconnect_update()` API
which is strangely specifically named for something that actually just
overwrites the connection options and is not really related to reconnect
(except by intention).
In any event, I think that in order to sensibly offer this functionality
someone has to remember the connection options so it might as well be the
binding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [cpp] Allow connection options to be updated for automatic reconnect.
> ---------------------------------------------------------------------
>
> Key: PROTON-2040
> URL: https://issues.apache.org/jira/browse/PROTON-2040
> Project: Qpid Proton
> Issue Type: New Feature
> Components: cpp-binding
> Affects Versions: proton-c-0.27.1
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Major
> Fix For: proton-c-0.28.0
>
>
> Allow modification of connection options prior to an automatic re-connect.
> Requested on mailing list:
>
> [https://lists.apache.org/thread.html/1fcd524de1e0d896a6f025470e0d774e051b8449dba0b9ddb3d0439e@%3Cusers.qpid.apache.org%3E]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
