[
https://issues.apache.org/jira/browse/DISPATCH-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834035#comment-16834035
]
ASF GitHub Bot commented on DISPATCH-1310:
------------------------------------------
codecov-io commented on issue #501: DISPATCH-1310: refactor delivery peer
handling
URL: https://github.com/apache/qpid-dispatch/pull/501#issuecomment-489704834
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/501?src=pr&el=h1)
Report
> Merging
[#501](https://codecov.io/gh/apache/qpid-dispatch/pull/501?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/2f0632a4c5005c657d664700d29114be31e3a97a?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `96.49%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/501?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 86.94% 86.94% -0.01%
==========================================
Files 87 87
Lines 19280 19290 +10
==========================================
+ Hits 16763 16771 +8
- Misses 2517 2519 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/501?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/501/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.53% <100%> (ø)` | :arrow_up: |
|
[src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/501/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j)
| `96.93% <100%> (-0.07%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/501/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.71% <100%> (-0.1%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/501/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.2% <100%> (-0.56%)` | :arrow_down: |
|
[src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/501/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=)
| `91.6% <100%> (+0.09%)` | :arrow_up: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/501/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `90.67% <95.45%> (+1.78%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/501/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.67% <0%> (-0.25%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/501/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.78% <0%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/501?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/501?src=pr&el=footer).
Last update
[2f0632a...f608c1d](https://codecov.io/gh/apache/qpid-dispatch/pull/501?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move delivery settlement and disposition propagation out of the core thread
> ---------------------------------------------------------------------------
>
> Key: DISPATCH-1310
> URL: https://issues.apache.org/jira/browse/DISPATCH-1310
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Affects Versions: 1.6.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Minor
> Labels: delivery-refactor
>
> In the current design all changes to a delivery's disposition and settlement
> state has to move through the core thread.
> Contrast this with the data associated with a delivery (held in the message
> content object) - data is moved between I/O threads without passing through
> the core thread.
> Moving the disposition and settlement state propagation to the I/O threads
> (like delivery data) will simplify its synchronization (2 thread rather than
> 3) and will (likely) improve performance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
