[
https://issues.apache.org/jira/browse/DISPATCH-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835105#comment-16835105
]
ASF GitHub Bot commented on DISPATCH-1326:
------------------------------------------
ted-ross commented on pull request #502: DISPATCH-1326 - Handling of anonymous
messages sent to edge routers. …
URL: https://github.com/apache/qpid-dispatch/pull/502#discussion_r281826325
##########
File path: src/router_node.c
##########
@@ -1383,6 +1383,18 @@ static void CORE_link_second_attach(void *context,
qdr_link_t *link, qdr_terminu
//
pn_link_open(qd_link_pn(qlink));
+ qd_connection_t *conn = qd_link_connection(qlink);
+ qdr_connection_t *qdr_conn = (qdr_connection_t*)
qd_connection_get_context(conn);
+ //
+ // Anonymous sender links coming in on edge connections must not have an
q2 limit set. This will ensure
+ // that several senders connected to the edge and sending large messages
dont choke that link.
+ // Regular sending links on the edge router connection will still be
subjected to q2 back pressure.
+ //
+ if (link->link_direction == QD_INCOMING && qdr_conn->core->router_mode ==
QD_ROUTER_MODE_INTERIOR && qdr_conn->role == QDR_ROLE_EDGE_CONNECTION &&
link->owning_addr == 0) {
Review comment:
This conditional is too narrow. It should disable q2-limiting on any link
over an edge or inter-router connection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Anonymous messages are released by edge router even if there is a receiver
> for the messages
> -------------------------------------------------------------------------------------------
>
> Key: DISPATCH-1326
> URL: https://issues.apache.org/jira/browse/DISPATCH-1326
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.5.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Attachments: E1.conf, I1.conf, simple_send_anon.py
>
>
> Steps to reproduce
> # Start one interior router and one edge router using the attached config
> files
> # Start a receiver using simple_recv.py and connect it to the interior router
> ##
> {noformat}
> python simple_recv.py -m1 --address 0.0.0.0:77778/examples{noformat}
> # Use the attached sender to send an anonymous message to the edge router
> ##
> {noformat}
> python simple_send_anon.py --address 0.0.0.0:5672 -m1{noformat}
> # The message must travel from the edge router to the interior router which
> in turn must forward it to the receiver. Instead the message is released as
> seen in the below frame trace.
>
> {noformat}
> [0x5603df87eb20]: -> SASL
> [0x5603df87eb20]: <- SASL
> [0x5603df87eb20]:0 <- @sasl-mechanisms(64)
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> [0x5603df87eb20]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS,
> initial-response=b"[email protected]"]
> [0x5603df87eb20]:0 <- @sasl-outcome(68) [code=0]
> [0x5603df87eb20]: -> AMQP
> [0x5603df87eb20]:0 -> @open(16)
> [container-id="c99c4867-447c-424a-8b4f-e8a406c71a57", hostname="0.0.0.0",
> channel-max=32767]
> [0x5603df87eb20]:0 -> @begin(17) [next-outgoing-id=0,
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x5603df87eb20]:0 -> @attach(18)
> [name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
> handle=0, role=false, snd-settle-mode=2, rcv-settle-mode=0,
> source=@source(40) [durable=0, timeout=0, dynamic=false], target=@target(41)
> [durable=0, timeout=0, dynamic=false], initial-delivery-count=0,
> max-message-size=0]
> [0x5603df87eb20]: <- AMQP
> [0x5603df87eb20]:0 <- @open(16) [container-id="Edge_66t2+y4DnWql1Vx",
> max-frame-size=16384, channel-max=32767, idle-time-out=8000,
> offered-capabilities=:"ANONYMOUS-RELAY",
> properties={:product="qpid-dispatch-router", :version="1.8.0-SNAPSHOT",
> :"qd.conn-id"=7}]
> [0x5603df87eb20]:0 <- @begin(17) [remote-channel=0, next-outgoing-id=0,
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x5603df87eb20]:0 <- @attach(18)
> [name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
> handle=0, role=true, snd-settle-mode=2, rcv-settle-mode=0,
> source=@source(40) [durable=0, expiry-policy=:"session-end", timeout=0,
> dynamic=false], target=@target(41) [durable=0, expiry-policy=:"session-end",
> timeout=0, dynamic=false], initial-delivery-count=0, max-message-size=0]
> [0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=0,
> incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647,
> handle=0, delivery-count=0, link-credit=250, drain=false]
> [0x5603df87eb20]:0 -> @transfer(20) [handle=0, delivery-id=0,
> delivery-tag=b"1", message-format=0] (53)
> "\x00SpE\x00Ss\xd0\x00\x00\x00\x11\x00\x00\x00\x03S\x01@\xa1\x08examples\x00Sw\xd1\x00\x00\x00\x10\x00\x00\x00\x02\xa1\x08sequenceT\x01"
> [0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=1,
> incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647,
> handle=0, delivery-count=1, link-credit=250, drain=false]
> [0x5603df87eb20]:0 <- @disposition(21) [role=true, first=0, settled=true,
> state=@released(38) []]
> [0x5603df87eb20]:0 -> (EMPTY FRAME)
> [0x5603df87eb20]:0 -> (EMPTY FRAME)
> ^C[gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
