[
https://issues.apache.org/jira/browse/DISPATCH-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847655#comment-16847655
]
ASF GitHub Bot commented on DISPATCH-1342:
------------------------------------------
codecov-io commented on issue #508: DISPATCH-1342 Replaced mutex with spin lock
on qd_message content
URL: https://github.com/apache/qpid-dispatch/pull/508#issuecomment-495685697
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/508?src=pr&el=h1)
Report
> Merging
[#508](https://codecov.io/gh/apache/qpid-dispatch/pull/508?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/9300914a8ddfa54854b87a34d1c241648dc79250?src=pr&el=desc)
will **decrease** coverage by `0.04%`.
> The diff coverage is `87.09%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/508?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 86.96% 86.91% -0.05%
==========================================
Files 87 87
Lines 19324 19340 +16
==========================================
+ Hits 16805 16810 +5
- Misses 2519 2530 +11
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/508?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `88.78% <100%> (ø)` | :arrow_up: |
|
[src/posix/threading.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL3Bvc2l4L3RocmVhZGluZy5j)
| `85.52% <75%> (-2.81%)` | :arrow_down: |
|
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
| `92.67% <0%> (-1.28%)` | :arrow_down: |
|
[...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==)
| `91.2% <0%> (-1.1%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.07% <0%> (-0.7%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.9% <0%> (-0.26%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.93% <0%> (+0.12%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `95% <0%> (+0.23%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/508/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.92% <0%> (+0.24%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/508?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/508?src=pr&el=footer).
Last update
[9300914...ca20411](https://codecov.io/gh/apache/qpid-dispatch/pull/508?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replaced mutex with spin lock on qd_message content
> ---------------------------------------------------
>
> Key: DISPATCH-1342
> URL: https://issues.apache.org/jira/browse/DISPATCH-1342
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
> Affects Versions: 1.7.0
> Reporter: Francesco Nigro
> Priority: Minor
>
> Given that qd_message creation and qd_message_free involves sys_mutex
> allocation/free and they are OS resources too, using spin locks will reduce
> the CPU/memory usage while performing such frequent operations.
> In addition it would make the router more reactive and resilient to OS thread
> scheduling while message->content is being concurrently accessed too, given
> that such accesses are meant to not last long and there is no need to involve
> OS arbitration to park/awake threads,
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
