[
https://issues.apache.org/jira/browse/DISPATCH-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853322#comment-16853322
]
ASF GitHub Bot commented on DISPATCH-1349:
------------------------------------------
ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is
wasting dst buffers available capacity
URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497819534
> Given that it would make the code more complex I can close this:
considering the context of utilization it won't bring any improvement +1
Say a message has 4 router hops on its way from sender to receiver, will
there ever be more than one buffer worth of each annotation (to_override or
trace or ingress) given each of them get a buffer size of 512 bytes.
@franz1981 is trying to compact these buffers but it comes into play *only* if
there is more than one buffer. In 99% percent of the cases one buffer is more
than enough space to hold one of these annotations,
I just realized that I am restating what @ChugR said earlier.
Although this PR is a good one, I agree that the context of utilization it
won't bring any improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qd_buffer_list_clone is wasting dst buffers available capacity
> --------------------------------------------------------------
>
> Key: DISPATCH-1349
> URL: https://issues.apache.org/jira/browse/DISPATCH-1349
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
> Affects Versions: 1.7.0
> Reporter: Francesco Nigro
> Priority: Minor
>
> qd_buffer_list_clone is not filling completely destination buffers available
> space (if any) after the first memcpy, allocating unnecessary qd_buffer(s)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
