[ 
https://issues.apache.org/jira/browse/DISPATCH-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860805#comment-16860805
 ] 

Robbie Gemmell commented on DISPATCH-1359:
------------------------------------------

If thats also possible then I would entirely agree. For the Java bits we often 
set a specific timeout on every individual method within the test class, not 
just the test class or run as a whole, for the same kind of reasons you are 
thinking.

When I asked Ganesh if the default test file timeout could be changed, I was 
mainly just thinking to avoid the CI jobs being killed currently because they 
time out themselves before the tests actually do. The suggested 300sec was from 
looking at the longest test file run in a slow TravisCI job, and going for 
something which exceeded that (by 70sec in this case) but was still suitably 
under the 600sec no-output timeout that Travis kills the job after (and 
hopefully low enough to try not running into the overall-time limit also). Not 
much point having a 1500sec timeout when the CI jobs typically fail long before 
it ever gets that far.

A more specific per-test timeout would be a much better improvement if that can 
be done also, fixing that issue and doing a far better job of avoiding 
excessive wasted time in the case of typically very fast tests.

As the current timeout seems to be configurable on the command line, I'd at 
least pick an initial value for it thats high enough to rarely be hit 
(exceptionally slow CI cases can always increase it with the command line 
option), but low enough that they make the mechanism effective in the test envs.

> Set ctest timeout to 300 seconds.
> ---------------------------------
>
>                 Key: DISPATCH-1359
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1359
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Container
>    Affects Versions: 1.7.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Minor
>
> Currently when running system tests, ctest has a default timeout of 1500 
> seconds which is way too long. So for example, system_tests_edge_router if it 
> should hang for some reason, gets terminated by ctest only after 1500 seconds 
> (25 mins). This is way too long.
> We need to set a smaller more reasonable timeout per test for ctest.
> system_tests_edge_router is the longest executing test in the test suite. 
> Looking at how long it takes to execute on a  slow Travis system, we have 
> reached the conclusion that 300 seconds would be a good timeout value for 
> ctest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to