[
https://issues.apache.org/jira/browse/QPIDJMS-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865949#comment-16865949
]
ASF GitHub Bot commented on QPIDJMS-461:
----------------------------------------
tabish121 commented on pull request #30: QPIDJMS-461 Optimize the default
message ID builder
URL: https://github.com/apache/qpid-jms/pull/30#discussion_r294500728
##########
File path:
qpid-jms-client/src/main/java/org/apache/qpid/jms/message/JmsMessageIDBuilder.java
##########
@@ -115,6 +119,20 @@ public String toString() {
public static JmsMessageIDBuilder create(String value) {
return valueOf(value.toUpperCase(Locale.ENGLISH)).createBuilder();
}
+
+ /**
+ * Validates the value given maps to the built in message ID builders
and
+ * return the builder enumeration that it maps to which can later be
used
+ * to create builders of that type.
+ *
+ * @param value
+ * The name of one of the built in message ID builders.
+ *
+ * @return the enumeration value that maps to the built in builder.
+ */
+ public static BUILTIN validate(String value) {
+ return valueOf(value.toUpperCase(Locale.ENGLISH));
Review comment:
I fixed that and pushed a new update for this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> JmsMessageIDBuilder::createMessageID can save StringBuilder allocations
> -----------------------------------------------------------------------
>
> Key: QPIDJMS-461
> URL: https://issues.apache.org/jira/browse/QPIDJMS-461
> Project: Qpid JMS
> Issue Type: Improvement
> Affects Versions: 0.44.0
> Reporter: Francesco Nigro
> Priority: Minor
> Attachments: screenshot-1.png
>
>
> JmsMessageIDBuilder::createMessageID doesn't seem able to correctly perform
> escape analysis on StringBuilder, allocating many of them.
> The intermediate StringBuilder could be saved into a thread local pool
> instead, saving unnececessary allocations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
