[
https://issues.apache.org/jira/browse/DISPATCH-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890210#comment-16890210
]
ASF GitHub Bot commented on DISPATCH-1389:
------------------------------------------
codecov-io commented on issue #542: DISPATCH-1389: force inlining of local
compose functions
URL: https://github.com/apache/qpid-dispatch/pull/542#issuecomment-513815502
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/542?src=pr&el=h1)
Report
> Merging
[#542](https://codecov.io/gh/apache/qpid-dispatch/pull/542?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/ab665701376e34b0a1bc213010f902e778aa7028?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/542?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #542 +/- ##
=========================================
+ Coverage 86.79% 86.8% +<.01%
=========================================
Files 87 87
Lines 19641 19640 -1
=========================================
Hits 17048 17048
+ Misses 2593 2592 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/542?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/compose.c](https://codecov.io/gh/apache/qpid-dispatch/pull/542/diff?src=pr&el=tree#diff-c3JjL2NvbXBvc2UuYw==)
| `89.24% <100%> (ø)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/542/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `67.83% <0%> (-0.51%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/542/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.37% <0%> (-0.26%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/542/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.57% <0%> (-0.25%)` | :arrow_down: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/542/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `86.53% <0%> (-0.2%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/542/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.81% <0%> (+0.11%)` | :arrow_up: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/542/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.23% <0%> (+0.19%)` | :arrow_up: |
|
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/542/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
| `93.94% <0%> (+1.27%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/542?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/542?src=pr&el=footer).
Last update
[ab66570...d55177a](https://codecov.io/gh/apache/qpid-dispatch/pull/542?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Optimize the parsing of message annotations
> -------------------------------------------
>
> Key: DISPATCH-1389
> URL: https://issues.apache.org/jira/browse/DISPATCH-1389
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
>
> Parsing message annotations, especially on the inter router incoming link,
> are quite expensive.
> For example, in a simple standalone router test the time it takes on average
> (on my puny laptop) to receive a message and hand it off to the core is ~1
> usec:
> TestRouterA: link MyReceiver count=500000 rx=1.094
> Compare that time to the same operation performed on the inbound router link
> on a two-hop router configuration:
> TestRouterB: link MyReceiver count=500000 rx=7.035
> On average it's 7x slower. Most of this time appears to be spent
> manipulating inbound message annotations.
>
> This Jira tracks work towards improving the performance of message annotation
> processing.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
