[
https://issues.apache.org/jira/browse/DISPATCH-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910509#comment-16910509
]
Ernest Allen commented on DISPATCH-1398:
----------------------------------------
My appologies Jiri. You are absolutely correct. The call to onRootReady has no
effect in both the stand-alone and the hawtio console.
The call to onTreeSelected is valid only in the hawtio console which uses
dnyatree instead to fancytree which is used by the stand-alone console.
The calls were ignored by angular and didn't have any effect when running the
app.
> "Expression with no effect" warning for console web
> ---------------------------------------------------
>
> Key: DISPATCH-1398
> URL: https://issues.apache.org/jira/browse/DISPATCH-1398
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Console
> Affects Versions: 1.8.0
> Reporter: Jiri Daněk
> Assignee: Ernest Allen
> Priority: Trivial
>
> {code:title=console/html/qdrList.html}
> 74 <div class="_treeContainer">
> CID 347402 (#2 of 2): Expression with no effect (NO_EFFECT)unused_expr:
> Accessing data with onTreeSelected and discarding the result. What was this
> code intended to accomplish?
> Perhaps this code is incomplete or mistyped in some way.
> 75 <div id="entityTree" onSelect="onTreeSelected"
> onRoot="onRootReady" hideRoot="true"></div>
> 76 <div ng-init="treeReady()"></div>
> 77 </div>
> {code}
> There may be some js magic involved, but after a brief inspection, the
> warning looks real to me. The stand-alone console seems to work ok, so it
> either has no influence on functionality, I did not thing of trying what's
> broken, (or it is a false positive warning).
> Could you please check?
> {code:title=html/tmplListTree.html}
> 32 <div class="pane-viewport">
> 33 <div class="pane-content">
> 34 <div class="treeContainer">
> CID 347337 (#3 of 3): Expression with no effect (NO_EFFECT)unused_expr:
> Accessing data with onTreeSelected and discarding the result. What was this
> code intended to accomplish?
> Perhaps this code is incomplete or mistyped in some way.
> 35 <div id="entityTree" onSelect="onTreeSelected"
> onRoot="onRootReady" hideRoot="true"></div>
> 36 <div ng-init="treeReady()"></div>
> 37 </div>
> 38 </div>
> 39 </div>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
