Ken Giusti created DISPATCH-1403:
------------------------------------

             Summary: Consolidate chained qd_buffer_t field handling code
                 Key: DISPATCH-1403
                 URL: https://issues.apache.org/jira/browse/DISPATCH-1403
             Project: Qpid Dispatch
          Issue Type: Improvement
          Components: Router Node
    Affects Versions: 1.8.0, 1.9.0
            Reporter: Ken Giusti
            Assignee: Ken Giusti
             Fix For: Backlog


There are many places in the router's C codebase where we need to work with 
data spanning a chained qd_buffer_t list.   In particular the low level 
operations such as:
* advance N bytes
* compare N bytes
* copy N bytes
are common throughout the code.

Here are examples from the iterator.c library:
[copy 
bytes|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L378]
[advance 
cursor|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L424]
[compare|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L467]

Similar logic is implemented in message.c and parse.c.

We should de-duplicate this code by providing a common implementation as part 
of the buffer handling code.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to