[
https://issues.apache.org/jira/browse/DISPATCH-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934623#comment-16934623
]
ASF GitHub Bot commented on DISPATCH-1430:
------------------------------------------
codecov-io commented on issue #569: DISPATCH-1430: handle array of capabilities
also
URL: https://github.com/apache/qpid-dispatch/pull/569#issuecomment-533652518
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/569?src=pr&el=h1)
Report
> Merging
[#569](https://codecov.io/gh/apache/qpid-dispatch/pull/569?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/759dfd6be57c2d32a371b1529194831356de61c5?src=pr&el=desc)
will **decrease** coverage by `0.04%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/569?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
- Coverage 86.35% 86.31% -0.05%
==========================================
Files 90 90
Lines 20364 20375 +11
==========================================
+ Hits 17585 17586 +1
- Misses 2779 2789 +10
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/569?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/terminus.c](https://codecov.io/gh/apache/qpid-dispatch/pull/569/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3Rlcm1pbnVzLmM=)
| `87.8% <75%> (-1.14%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/569/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.7% <0%> (-0.76%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/569/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `92.89% <0%> (-0.25%)` | :arrow_down: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/569/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `81.36% <0%> (-0.19%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/569?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/569?src=pr&el=footer).
Last update
[759dfd6...9417e64](https://codecov.io/gh/apache/qpid-dispatch/pull/569?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> qd.waypoint capability not recognised if encoded as array
> ---------------------------------------------------------
>
> Key: DISPATCH-1430
> URL: https://issues.apache.org/jira/browse/DISPATCH-1430
> Project: Qpid Dispatch
> Issue Type: Bug
> Reporter: Gordon Sim
> Priority: Major
>
> The qd.waypoint capability on a linkcurrently has to be specified as a single
> symbol. Not all libraries will encode even a single capability in this way,
> pusing instead an array with a single item. (Both are legitimate AMQP
> encodings).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
